Henry Robinson has posted comments on this change. Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7418/1/CMakeLists.txt File CMakeLists.txt: PS1, Line 125: impala_add_thirdparty_lib > upper case function name? It seems weird that the declaration is lower case Done - I have no idea what good CMake style looks like :) Line 136: if (NOT STATIC_LIB) > Could we simplify this to: That doesn't handle the case where only the static library is provided (which is true for several dependencies at the moment). This is simpler tho: if ((BUILD_SHARED_LIBS AND SHARED_LIB) OR NOT STATIC_LIB) else endif() -- To view, visit http://gerrit.cloudera.org:8080/7418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7a6bc5610aaf2450f91348d94cfb984c6a4b78d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
