Henry Robinson has posted comments on this change. Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7418/3/CMakeLists.txt File CMakeLists.txt: PS3, Line 155: > Is there a reason to not just pass an empty string "" for the shared librar Please look at the most recent patch - I changed it to exactly what you suggest. -- To view, visit http://gerrit.cloudera.org:8080/7418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7a6bc5610aaf2450f91348d94cfb984c6a4b78d Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
