Henry Robinson has posted comments on this change. Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7418/3/CMakeLists.txt File CMakeLists.txt: PS3, Line 155: {BZIP2_STATIC_LIBRARIES > BZIP2_SHARED_LIBRARIES ? Currently, there is only BZIP2_LIBRARIES in the Fi This was just to ensure that the static lib was used in both cases - but that's handled by IMPALA_ADD_THIRDPARTY_LIB. Our toolchain doesn't include a shared version of libbzip2. PS3, Line 183: GTEST_LIBRARY > GTEST_STATIC_LIBRARY Done -- To view, visit http://gerrit.cloudera.org:8080/7418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7a6bc5610aaf2450f91348d94cfb984c6a4b78d Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
