Tim Armstrong has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/runtime/decimal-test.cc File be/src/runtime/decimal-test.cc: Line 305: // When the absolute value of the exponent becomes too large, it is considered This seems a bit weird - it seems like it should be underflow. It seems like this might lead to CastToDecimalVal() returning the wrong thing, since it has different behaviour on underflow and overflow. http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/string-parser.h File be/src/util/string-parser.h: Line 221: T divisor = DecimalUtil::GetScaleMultiplier<T>(shift); I must be missing something, but I don't understand how divisor can ever be -1, since GetScaleMultiplier returns 1 multiplied by "scale" 10s. PS1, Line 225: DCHECK DCHECK_EQ -- To view, visit http://gerrit.cloudera.org:8080/7517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5eb5b64a6924af2e8eb7f9a50da67015757efe Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
