Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/runtime/decimal-test.cc File be/src/runtime/decimal-test.cc: Line 305: // When the absolute value of the exponent becomes too large, it is considered > This seems a bit weird - it seems like it should be underflow. It seems lik Changed the be code so that a large negative number would lead to an underflow (instead of overflow). http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/decimal-util.h File be/src/util/decimal-util.h: Line 63: DCHECK_GE(result * 10, result); > The generic integer overflow support wasn't added until gcc5 I believe. Agr Added a TODO. http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/string-parser.h File be/src/util/string-parser.h: PS1, Line 225: DCHECK > DCHECK_EQ DCHECK_EQ doesn't work with int128. Added a comment. -- To view, visit http://gerrit.cloudera.org:8080/7517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5eb5b64a6924af2e8eb7f9a50da67015757efe Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
