anujphadke has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/string-parser.h File be/src/util/string-parser.h: Line 221: T divisor = DecimalUtil::GetScaleMultiplier<T>(shift); > I must be missing something, but I don't understand how divisor can ever be I think it can be a huge negative number once it overflows. Ex when T is an int - int result = 1; for(int i=0; i <= 11; i++) { result *= 10; } result is -727379968 -- To view, visit http://gerrit.cloudera.org:8080/7517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5eb5b64a6924af2e8eb7f9a50da67015757efe Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes
