Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5722: Fix string to decimal cast ......................................................................
IMPALA-5722: Fix string to decimal cast When converting a string to a decimal, we didn't handle the case where the exponent is a large negative number. The function for computing the divisor returns -1 when the exponent is too large. The problem is fixed by making sure that the divisor is positive. Testing: -Added decimal tests. Change-Id: I1f5eb5b64a6924af2e8eb7f9a50da67015757efe Reviewed-on: http://gerrit.cloudera.org:8080/7517 Reviewed-by: Tim Armstrong <[email protected]> Reviewed-by: Jim Apple <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/decimal-test.cc M be/src/util/decimal-util.h M be/src/util/string-parser.h 3 files changed, 31 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Verified Jim Apple: Looks good to me, approved Tim Armstrong: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/7517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f5eb5b64a6924af2e8eb7f9a50da67015757efe Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]>
