Henry Robinson has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface ......................................................................
Patch Set 1: (1 comment) Quick question before I get stuck in - did you evaluate the complexity of building this class hierarchy vs having the users of the datastream interfaces keeping a pointer to both possible implementations, and using FLAGS_use_krpc to decide which one to call into? It would be a bit tedious in, e.g. exchange-node.cc - but it would be self-contained, and it would be easy to undo the changes when we standardize on one solution. With the class hierarchy approach, I'm a bit concerned about the amount of code we introduce that will ultimately be removed. http://gerrit.cloudera.org:8080/#/c/7542/1/be/src/runtime/sender-queue-base.h File be/src/runtime/sender-queue-base.h: PS1, Line 28: #include "common/names.h" this shouldn't be included in a .h file -- To view, visit http://gerrit.cloudera.org:8080/7542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
