Michael Ho has posted comments on this change.

Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream 
interface
......................................................................


Patch Set 1:

FWIW, I was actually expecting that the renaming would happen later. This makes 
the change easier to review (as one can tell if anything is actually changed in 
DSS code).

I understand this is optimizing for the eventual outcome which is to remove 
thrift-data* but we may still have the code with us for a couple of releases 
(as backup options at least in the initial release of KRPC). What do you think ?

-- 
To view, visit http://gerrit.cloudera.org:8080/7542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-HasComments: No

Reply via email to