Michael Ho has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build ......................................................................
Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/5717/12/CMakeLists.txt File CMakeLists.txt: PS12, Line 155: set(OPENSSL_FOUND ON) : set(OPENSSL_STATIC_LINKING ON) : set(OPENSSL_INCLUDE_DIR ${OPENSSL_ROOT}/include) : set(OPENSSL_SSL_LIBRARY ${OPENSSL_ROOT}/lib/libssl.a) : set(OPENSSL_CRYPTO_LIBRARY ${OPENSSL_ROOT}/lib/libcrypto.a) : set(OPENSSL_VERSION $ENV{IMPALA_OPENSSL_VERSION}) : message(STATUS "OpenSSL 1.0.1+ NOT found in system dirs. Defaulting to static linking " : "of OpenSSL $ENV{IMPALA_OPENSSL_VERSION} from toolchain") Ideally, we should use dynamic linking, right ? Is this a temporary workaround because of the dependency on the packaging script change ? -- To view, visit http://gerrit.cloudera.org:8080/5717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f327810066bee7f3ac107b0295480fb9ed45e14 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
