Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build ......................................................................
Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/5717/15/CMakeLists.txt File CMakeLists.txt: PS15, Line 159: set(OPENSSL_STATIC_LINKING ON) > This line should not exist, right ? Done http://gerrit.cloudera.org:8080/#/c/5717/15/be/src/kudu/security/init.cc File be/src/kudu/security/init.cc: PS15, Line 351: #if defined( > nit: #ifdef to be consistent with #ifndef above. Feel free to ignore. Done http://gerrit.cloudera.org:8080/#/c/5717/15/be/src/kudu/security/token_verifier.cc File be/src/kudu/security/token_verifier.cc: PS15, Line 160: DCHECK(false); : return nullptr; > Should this be done in the Kudu code base too or Impala is somehow differen Perhaps - ISTR that this triggered compile warnings for us, but Kudu's compilation settings might be different. -- To view, visit http://gerrit.cloudera.org:8080/5717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f327810066bee7f3ac107b0295480fb9ed45e14 Gerrit-PatchSet: 15 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
