Michael Ho has posted comments on this change.

Change subject: IMPALA-4669: [SECURITY] Add security library to build
......................................................................


Patch Set 15:

(3 comments)

Change LGTM. I assume you have tested this with packaging build, right ?
Also, for the change in be/src/kudu/security/*, do you plan to make the same 
changes in Kudu code base if that's not done already ?

http://gerrit.cloudera.org:8080/#/c/5717/15/CMakeLists.txt
File CMakeLists.txt:

PS15, Line 159: set(OPENSSL_STATIC_LINKING ON)
This line should not exist, right ?


http://gerrit.cloudera.org:8080/#/c/5717/15/be/src/kudu/security/init.cc
File be/src/kudu/security/init.cc:

PS15, Line 351: #if defined(
nit: #ifdef to be consistent with #ifndef above. Feel free to ignore.


http://gerrit.cloudera.org:8080/#/c/5717/15/be/src/kudu/security/token_verifier.cc
File be/src/kudu/security/token_verifier.cc:

PS15, Line 160:   DCHECK(false);
              :   return nullptr;
Should this be done in the Kudu code base too or Impala is somehow different ?


-- 
To view, visit http://gerrit.cloudera.org:8080/5717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f327810066bee7f3ac107b0295480fb9ed45e14
Gerrit-PatchSet: 15
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to