Jim Apple has posted comments on this change. Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil ......................................................................
Patch Set 4: (5 comments) I may not have expressed my previous comments in a simple way. Let me try again. http://gerrit.cloudera.org:8080/#/c/7414/4/be/src/gutil/hash/hash.h File be/src/gutil/hash/hash.h: Line 96: using std::hash; Can these two lines be deleted? Line 187: #include <ext/hash_set> Can this line be deleted? Line 208: bool operator()(const uint128& a, const uint128& b) const { Can this MSCV stuff be deleted? Line 215: // MSVC's STL requires an ever-so slightly different decl Can this MSVC stuff be deleted? Line 244: bool operator()(const pair<First, Second>& a, Can this MSVC stuff be deleted? -- To view, visit http://gerrit.cloudera.org:8080/7414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06af30fd15acd43a60e3c30af54056c96520b6e9 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
