Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" ......................................................................
Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/7530/14/be/src/runtime/timestamp-parse-util.h File be/src/runtime/timestamp-parse-util.h: PS14, Line 23: #include "runtime/timestamp-value.h" > There will still be a boost header for ptime. Is that desirable? A referenc That's a good point about ptime still being needed, though probably unavoidable without more serious refactoring that probably isn't worth it. Also, that's nice if you can just keep using the reference w/ the forward declaration. Thanks for pointing that out. -- To view, visit http://gerrit.cloudera.org:8080/7530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896 Gerrit-PatchSet: 14 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
