Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" ......................................................................
Patch Set 13: (6 comments) http://gerrit.cloudera.org:8080/#/c/7530/13/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: Line 546: if (realign_year) { dcheck here that dt_ctx.century_start_ptime is a valid ptime to make sure it was actually set properly, you can call is_special(). http://gerrit.cloudera.org:8080/#/c/7530/13/be/src/runtime/timestamp-parse-util.h File be/src/runtime/timestamp-parse-util.h: PS13, Line 140: century_start_ptime how about century_break_ptime ? century start sounds like it should be 1900, 2000, etc. PS13, Line 141: /// The year of century_start_time. : boost::gregorian::date::year_type century_start_year; why store this instead of using ptime.date().year() ? I think that shouldn't require any conversion, should be fast. PS13, Line 152: start of century century break PS13, Line 155: SetCenturyStart SetCenturyBreak PS13, Line 163: Reset I missed this before, but this should reset the new members. Please set century_start_time to not_a_date_time -- To view, visit http://gerrit.cloudera.org:8080/7530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
