Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" ......................................................................
Patch Set 14: (1 comment) Thanks! Looks really good, just 1 more change, sorry I didn't think of it sooner. http://gerrit.cloudera.org:8080/#/c/7530/14/be/src/runtime/timestamp-parse-util.h File be/src/runtime/timestamp-parse-util.h: PS14, Line 23: #include "runtime/timestamp-value.h" just realized after the last change that you can remove this header include (move to the .cc) if you: 1) forward declare TimestampValue 2) move SetCenturyBreak() in the .cc 3) change the fn args to take a 'const TimestampValue*' instead of a reference. This will help avoid build times from increasing. -- To view, visit http://gerrit.cloudera.org:8080/7530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896 Gerrit-PatchSet: 14 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
