Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded
......................................................................


Patch Set 1:

(3 comments)

Looks good, just a couple of minor things.

http://gerrit.cloudera.org:8080/#/c/7597/1/be/src/runtime/mem-tracker.cc
File be/src/runtime/mem-tracker.cc:

PS1, Line 341: (process_capacity < failed_allocation_size)
nit: unnecessary parens.


PS1, Line 344: 1
What do you think about logging 2 levels down to get the query MemTrackers? 
Might be overkill but otoh the query IDs are useful to track down the offenders 
(at least until we have a better means of tracking down which queries are using 
memory on which backends).

Maybe we should make these values constants as well. E.g. 
POOL_MEMTRACKER_DEPTH, QUERY_MEMTRACKER_DEPTH.


http://gerrit.cloudera.org:8080/#/c/7597/1/be/src/runtime/mem-tracker.h
File be/src/runtime/mem-tracker.h:

PS1, Line 324:       int max_recursive_levels = INT_MAX
Maybe we should make it a required argument to force new callsites to think 
about whether it makes sense to dump the full thing?


-- 
To view, visit http://gerrit.cloudera.org:8080/7597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib151c3894d4c43b508779e6809d77e2f8af89cf2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to