Dan Hecht has posted comments on this change. Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7597/3/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: PS3, Line 353: logged_query_tracker rather than introducing another control variable, why not just 'state == nullptr'? the comment explains it (especially if you make the comment order match the code order of conditionals). http://gerrit.cloudera.org:8080/#/c/7597/3/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: PS3, Line 338: summary of the queries does this mean it it dumps the query-level tracker but nothing below? if so, maybe be more explicit about this. -- To view, visit http://gerrit.cloudera.org:8080/7597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib151c3894d4c43b508779e6809d77e2f8af89cf2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
