Joe McDonnell has posted comments on this change. Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded ......................................................................
Patch Set 1: (3 comments) Rebased all the way. http://gerrit.cloudera.org:8080/#/c/7597/1/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: PS1, Line 341: (process_capacity < failed_allocation_size) > nit: unnecessary parens. Done PS1, Line 344: 1 > +1 I was wondering about this as well. The pool tracker is probably not goi Changed this to two levels. Stress tests show that this isn't a problem. I also added constants for the code to use. http://gerrit.cloudera.org:8080/#/c/7597/1/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: PS1, Line 324: int max_recursive_levels = INT_MAX > Maybe we should make it a required argument to force new callsites to think Changed this to a required argument. -- To view, visit http://gerrit.cloudera.org:8080/7597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib151c3894d4c43b508779e6809d77e2f8af89cf2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
