Tim Armstrong has posted comments on this change. Change subject: IMPALA-5768: Better developer documentation ......................................................................
Patch Set 4: Code-Review+1 (1 comment) LGTM. I'll give other reviewers a chance to weigh in. http://gerrit.cloudera.org:8080/#/c/7350/4/README.md File README.md: Line 105: | SENTRY_HOME | "${CDH_COMPONENTS_HOME}/toolchain/" | | Should this be /sentry-?? or something? -- To view, visit http://gerrit.cloudera.org:8080/7350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
