Tim Armstrong has posted comments on this change. Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7380/5/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: PS5, Line 266: uint64_t val = consumption_metric_->value(); : if (negate_consumption_metric_) val = -val; > val needs to be signed. Hah, yeah this was working by accident because it overflowed when converted back to int64_t for consumption_->Set() -- To view, visit http://gerrit.cloudera.org:8080/7380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb1fa3110dc893321f9f4e8ced6b7ede12194dad Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
