Tim Armstrong has posted comments on this change. Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7380/6//COMMIT_MSG Commit Message: Line 14: reservation + cached buffers - unused reservation > wouldn't this be equivalent: It doesn't help here for a couple of reasons: * The pool memory consumption has to include reservation, so that term must be part of the equation. We can't avoid this without completing changing memory reporting. * There's no easy way to compute the used reservation globally though without walking the entire ReservationTracker tree, since "using" reservation only updates the local state of ReservationTracker. -- To view, visit http://gerrit.cloudera.org:8080/7380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb1fa3110dc893321f9f4e8ced6b7ede12194dad Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
