Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5773: Correctly account for memory used in data stream 
receiver queue
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7646/1/be/src/runtime/row-batch.cc
File be/src/runtime/row-batch.cc:

PS1, Line 343: int
Would it make sense to change to int64_t to avoid potential overflows? Not sure 
if that causes problems at any callsites.


http://gerrit.cloudera.org:8080/#/c/7646/1/be/src/runtime/row-batch.h
File be/src/runtime/row-batch.h:

Line 304:   /// deserialized form.
Maybe mention compression explicitly. E.g. serialized (i.e. compressed) or 
deserialized (i.e. uncompressed).


-- 
To view, visit http://gerrit.cloudera.org:8080/7646
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e90f9596ee984438e3373af05e84d361702ca6a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to