Henry Robinson has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue ......................................................................
Patch Set 3: (2 comments) I didn't notice any significant performance regressions when I ran TPCDS on a 16-node cluster. But this is an obvious correctness issue; we'll do more perf analysis shortly. http://gerrit.cloudera.org:8080/#/c/7646/3/be/src/runtime/data-stream-mgr.cc File be/src/runtime/data-stream-mgr.cc: PS3, Line 80: int buffer_size > For consistency, should this be int64_t too ? Done http://gerrit.cloudera.org:8080/#/c/7646/3/be/src/runtime/data-stream-recvr.cc File be/src/runtime/data-stream-recvr.cc: PS3, Line 154: int64_t batch_size = RowBatch::GetDeserializedSize(thrift_batch); > nit: move this closer to l165 where it's used Done -- To view, visit http://gerrit.cloudera.org:8080/7646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e90f9596ee984438e3373af05e84d361702ca6a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
