Tim Armstrong has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7646/2/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: PS2, Line 344: int Needs to be an int64_t now PS2, Line 351: int Needs to be an int64_t now http://gerrit.cloudera.org:8080/#/c/7646/1/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 304: /// deserialized form. If a row batch is compressed, its serialized size can be much > Done - not all serialized batches are compressed, so need to be a bit caref Good point. I think the new comment is helpful. -- To view, visit http://gerrit.cloudera.org:8080/7646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e90f9596ee984438e3373af05e84d361702ca6a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
