Tianyi Wang has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar ......................................................................
Patch Set 6: D > (7 comments) Done(Test is still ongoing). I have a question: when doing error handling that is not exposed to user/Thrift, is Status class recommended to use? It seems its untyped style is mainly for Thrift transmission. -- To view, visit http://gerrit.cloudera.org:8080/7642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47eed045f21c6ed3a8decf422ce8429fc66c4322 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
