Hello Tim Armstrong, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7642 to look at the new patch set (#9). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar ...................................................................... IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it is not handled in two places. This patch checks the return value/exception, logs if there is error and return error to the caller. A helper class JniUtfCharGuard is added to jni-util.h/cc to manage the lifetime. Change-Id: I47eed045f21c6ed3a8decf422ce8429fc66c4322 --- M be/src/common/status.h M be/src/util/jni-util.cc M be/src/util/jni-util.h M be/src/util/logging-support.cc 4 files changed, 68 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/7642/9 -- To view, visit http://gerrit.cloudera.org:8080/7642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I47eed045f21c6ed3a8decf422ce8429fc66c4322 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>