Tim Armstrong has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar ......................................................................
Patch Set 7: (4 comments) Yeah, we use Status almost universally for error handling. We don't currently distinguish very clearly between internal-only status codes and user-visible status codes. Thanks for adding this class, should make this error handling less error-prone. http://gerrit.cloudera.org:8080/#/c/7642/7/be/src/util/jni-util.cc File be/src/util/jni-util.cc: PS7, Line 32: auto Might as well declare it as 'bool', it's the same number of characters. http://gerrit.cloudera.org:8080/#/c/7642/7/be/src/util/jni-util.h File be/src/util/jni-util.h: PS7, Line 145: Jni JNI? Line 148: JNIEnv* env; Are these meant to be private? Usually our convention is to have a private: section below the public interface. Line 166: const char* get() { return utf_chars; } We should add a DISALLOW_COPY_AND_ASSIGN(JniUtfCharGuard); to disable the copy constructors (weird things would happen). -- To view, visit http://gerrit.cloudera.org:8080/7642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47eed045f21c6ed3a8decf422ce8429fc66c4322 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
