Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations ......................................................................
Patch Set 6: (1 comment) The more I think about this, the more I think it's a shame that we have to introduce this new concept to fix up the accounting that we print. Why can't we special case the root process tracker output that we print and be more precise about what 'Total' means there (Total Used?) / add a new field in the first line for the total including unused (Total?). http://gerrit.cloudera.org:8080/#/c/7380/6//COMMIT_MSG Commit Message: PS6, Line 29: -8.25 MB > It seems weird having the user-visible metric be a negative quantity. We co Yeah I'm in favor of removing the UIntGauges for the memory metrics. What will internal only mean? That it doesn't show up on /metrics ? I wonder if we can just come up with a name that makes more sense to be negative. I don't see any general problem with a metric being negative, it's just that we don't have a good name for it. -- To view, visit http://gerrit.cloudera.org:8080/7380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb1fa3110dc893321f9f4e8ced6b7ede12194dad Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
