Tianyi Wang has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7683/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 134: string path; > We shouldn't need to do this (it always won't work on a statically linked b Without this it crashes with "Program used external function ... which could not be resolved" during codegen. http://gerrit.cloudera.org:8080/#/c/7683/2/be/src/exec/hdfs-scanner-ir.cc File be/src/exec/hdfs-scanner-ir.cc: Line 131: Decimal4Value::value_type IrStringToDecimal4(const char* s, int len, int type_precision, > What happens if you just return a Decimal4Value? The IR generated by Clang still reads decimalblah and we will need a bitcast in CodegenWriteSlot() just like the int128 case. -- To view, visit http://gerrit.cloudera.org:8080/7683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia65820e969d59094dc92d912a5279fa90f6b179d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
