Tianyi Wang has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7683/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 134: string path; > Without this it crashes with "Program used external function ... which coul I'm sorry it works without this. I have no idea how I came to that conclusion and accidentally "fixed" it. http://gerrit.cloudera.org:8080/#/c/7683/2/be/src/exec/hdfs-scanner-ir.cc File be/src/exec/hdfs-scanner-ir.cc: PS2, Line 84: FlowAsFailure > IMO it would be clearer to inline this function at the 3 callsites. Done http://gerrit.cloudera.org:8080/#/c/7683/2/be/src/exec/text-converter.cc File be/src/exec/text-converter.cc: Line 234: case 12: > case 12 seems unnecessary given we have a default case already. Done. This is copied from TextConverter::WriteSlot and there is an unnecessary case there by the way. http://gerrit.cloudera.org:8080/#/c/7683/2/be/src/util/string-parser.h File be/src/util/string-parser.h: PS2, Line 600: : /// StringToDecimal<T> is too big to be called from IR. These are proxy functions : /// linked into util library > I would reword this to something like: Done -- To view, visit http://gerrit.cloudera.org:8080/7683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia65820e969d59094dc92d912a5279fa90f6b179d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
