Tianyi Wang has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7683/2//COMMIT_MSG Commit Message: Line 14: StringToDecimal out of LLVM IR. > Can you add a line break to separate the paragraphs to make it more readabl Done PS2, Line 15: libUtil.so > nit: libUtil, since we use static linking too. Done Line 19: > Did you do an experiment to see how much scanning sped up for a larger tabl Statistics added http://gerrit.cloudera.org:8080/#/c/7683/2/be/src/exec/hdfs-scanner-ir.cc File be/src/exec/hdfs-scanner-ir.cc: Line 131: Decimal4Value::value_type IrStringToDecimal4(const char* s, int len, int type_precision, > Ah ok, makes sense. Applied. Good idea -- To view, visit http://gerrit.cloudera.org:8080/7683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia65820e969d59094dc92d912a5279fa90f6b179d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
