Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7679/1//COMMIT_MSG Commit Message: PS1, Line 10: https://github.com/cloudera/squeasel/commit/1e5f611 This looks like it's pointing to the wrong commit. http://gerrit.cloudera.org:8080/#/c/7679/1/be/src/thirdparty/squeasel/squeasel.c File be/src/thirdparty/squeasel/squeasel.c: Line 4232: #endif Should we explicitly throw an error or show a warning if they opt for tlsv1_1 or tlsv1_2, instead of silently setting tlsv1, with OPENSSL_VERSION_NUMBER < OPENSSL_VERSION_HAS_TLS_1_1 ? http://gerrit.cloudera.org:8080/#/c/7679/1/be/src/util/webserver-test.cc File be/src/util/webserver-test.cc: PS1, Line 251: SslBadCipherSuite Let's add a good cipher suite test too. -- To view, visit http://gerrit.cloudera.org:8080/7679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23fb17257098992c65e50c1e83a905c9a85db6a2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
