Henry Robinson has posted comments on this change. Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7679/1//COMMIT_MSG Commit Message: PS1, Line 10: https://github.com/cloudera/squeasel/commit/1e5f611 > This looks like it's pointing to the wrong commit. It's the right commit - a bugfix for the previous one. http://gerrit.cloudera.org:8080/#/c/7679/1/be/src/thirdparty/squeasel/squeasel.c File be/src/thirdparty/squeasel/squeasel.c: Line 4232: #endif > Should we explicitly throw an error or show a warning if they opt for tlsv1 I don't think that's what happens - won't the 'else' branch below get taken? -- To view, visit http://gerrit.cloudera.org:8080/7679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23fb17257098992c65e50c1e83a905c9a85db6a2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
