Henry Robinson has posted comments on this change.

Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7679/1//COMMIT_MSG
Commit Message:

PS1, Line 10: https://github.com/cloudera/squeasel/commit/1e5f611
> I would add a reference to this as well, to avoid confusion:
Not to be pedantic, but this conveys what I'm trying to say: I took squeasel as 
of this particular commit, i.e. the snapshot of the file at this commit as the 
sum of all the commits before it. I've tried a slight rewording.


http://gerrit.cloudera.org:8080/#/c/7679/2/be/src/util/webserver-test.cc
File be/src/util/webserver-test.cc:

PS2, Line 251: SslBadCipherSuite
> Thanks for adding the test. This shouldn't be called "SslBadCipherSuite" no
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23fb17257098992c65e50c1e83a905c9a85db6a2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to