Alex Behm has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7639/5/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 297: boundary_column_.Clear(); Can we use the existing CopyBoundaryField() function for consistency? Otherwise, a future reader might be confused why we are not using CopyBoundaryField() here. I believe we could call that after delimited_text_parser_->FillColumns(), instead of coping before calling FillColumns(). -- To view, visit http://gerrit.cloudera.org:8080/7639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60ba5c113aefd17f697c1888fd46a237ef396540 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
