Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5776: Write partial tuple to the correct mempool ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/7639/2/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 808: // The partial tuple pool is cleared after the data has been copied out of it to > Another idea: Add a separate function for copying the partial tuple into th Created a function for copying the partial tuple into output batch. http://gerrit.cloudera.org:8080/#/c/7639/4/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: PS4, Line 317: partial_tuple_empty_ > Comment needs update Done http://gerrit.cloudera.org:8080/#/c/7639/4/be/src/exec/hdfs-text-scanner.h File be/src/exec/hdfs-text-scanner.h: Line 194: boost::scoped_ptr<MemPool> boundary_pool_; > So my question is really whether there's a good reason why the lifetime nee Fixed the place where we forget to copy the data out. Removed the new memory pool that I added. Line 199: StringBuffer boundary_row_; > Can you clarify whether this data will be referenced by the output batches. Done Line 202: StringBuffer boundary_column_; > Same here. It looks like some attempt is made to copy data out of this colu Done -- To view, visit http://gerrit.cloudera.org:8080/7639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60ba5c113aefd17f697c1888fd46a237ef396540 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
