Tim Armstrong has posted comments on this change. Change subject: IMPALA-5776: Write partial tuple to the correct mempool ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7639/4/be/src/exec/hdfs-text-scanner.h File be/src/exec/hdfs-text-scanner.h: Line 194: boost::scoped_ptr<MemPool> boundary_pool_; > So WriteSlot() doesn't copy when processing it's input string, but why are So my question is really whether there's a good reason why the lifetime needs to be different. If it's just that we're missing a copy in some place then we should fix that instead of trying to work around it. -- To view, visit http://gerrit.cloudera.org:8080/7639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60ba5c113aefd17f697c1888fd46a237ef396540 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
