Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7711/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: Line 556: value->AddMember("num_instances", fragments_.size(), document->GetAllocator()); I think we should include some form of total_ranges_complete_ in this page. I'd prefer something like num_remaining_scan_ranges, if its easy to plumb that value (completed scan ranges is available directly in the backend state). I've seen many queries stuck in reading scan ranges (potentially due to some underlying FS problem) causing the whole pipeline to hang. So this metric might help such cases. PS1, Line 569: status_ use GetStatus()? It takes the BackendState::lock_ http://gerrit.cloudera.org:8080/#/c/7711/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: PS1, Line 710: request_state UNLIKELY(request_state.get()...) ? http://gerrit.cloudera.org:8080/#/c/7711/1/www/query_backends.tmpl File www/query_backends.tmpl: Line 57: Does it make sense to add a checkbox to show only backends with unfinished fragments? Typically while debugging queries with tons of fragments we will be interested only in laggers. -- To view, visit http://gerrit.cloudera.org:8080/7711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5b3b0fb8f4188da56da593199f41ce6fab99767 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
