Henry Robinson has posted comments on this change.

Change subject: IMPALA-5811: Add 'backends' tab to query details pages
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7711/4/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

Line 183:           assert len(response_json['backend_states']) == 3
> This check is only accurate on the 3-node minicluster right - we probably n
Good point! Changed the check to be > 0 - more robust to other test 
environments without having to skip it (and also won't be sensitive to changes 
in parallelism for these query plans).


-- 
To view, visit http://gerrit.cloudera.org:8080/7711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5b3b0fb8f4188da56da593199f41ce6fab99767
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to