Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages ......................................................................
Patch Set 3: (2 comments) Added a test, thanks for the suggestion! http://gerrit.cloudera.org:8080/#/c/7711/3/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: PS3, Line 557: IsDone > after Thomas' change, the callers of this are responsible for taking the lo Done PS3, Line 566: last_report_time_ms_ > This function is inconsistent about whether it acquires 'lock_' when readin Done -- To view, visit http://gerrit.cloudera.org:8080/7711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5b3b0fb8f4188da56da593199f41ce6fab99767 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
