Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5799: Kudu DML can crash if schema has changed ......................................................................
Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/7688/2//COMMIT_MSG Commit Message: PS2, Line 11: ' > this one should be removed No, this is right now: 'if it is modified' http://gerrit.cloudera.org:8080/#/c/7688/2/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: PS2, Line 146: olumns[i]; > wouldn't this not work when the insert specifies all columns, i.e. referenc Done PS2, Line 146: i : kudu_table_sink_.referenced_columns[i]; : if (table_->schema().num_columns() <= col_idx) { : return Status(strings::Substitute( : > this makes me a bit nervous because it seems like expecting the list is in Done PS2, Line 151: mnT > nit: col_idx maybe Done http://gerrit.cloudera.org:8080/#/c/7688/2/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: Line 412: for i in range(0, iters): > comment that this sleeps for up to a second Done PS2, Line 414: try: > nit: move this outside of the loop Done -- To view, visit http://gerrit.cloudera.org:8080/7688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fd6bf164310df0041144f75f5ee722665e9f587 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
