Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5799: Kudu DML can crash if schema has changed ......................................................................
IMPALA-5799: Kudu DML can crash if schema has changed We check that the number/types of columns in a Kudu DML match the underlying table during analysis. However, it's possible that the schema may be modified between analysis and execution, and if it's modified in incompatible ways it can cause Impala to crash. Once the KuduTable object has been opened by the KuduTableSink, its schema will remain the same, so we can check in Open() that the schema is what we're expecting. If the schema changes between Open() and when the WriteOp is sent to Kudu, Kudu will send back an error and we already handle this gracefully. Testing: - Added an e2e test that concurrently inserts into a Kudu table while dropping and then adding a column. It relies on timing, but running in a loop locally it caused Impala to crash every time without this change. Change-Id: I9fd6bf164310df0041144f75f5ee722665e9f587 Reviewed-on: http://gerrit.cloudera.org:8080/7688 Reviewed-by: Matthew Jacobs <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/exec/kudu-table-sink.cc M be/src/exec/kudu-util.cc M be/src/exec/kudu-util.h M tests/query_test/test_kudu.py 4 files changed, 85 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Verified Matthew Jacobs: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fd6bf164310df0041144f75f5ee722665e9f587 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
