Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5799: Kudu DML can crash if schema has changed ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7688/3/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: PS3, Line 147: <= > '<' ? Suppose you have a table with '3' columns. The highest col_idx that would be valid would be '2' (0-indexed), so a col_idx of '3' (which is = to the number of columns) would be invalid. Its equivalent to: if (!(col_idx < table_->schema().num_columns())) {...} -- To view, visit http://gerrit.cloudera.org:8080/7688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fd6bf164310df0041144f75f5ee722665e9f587 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
