Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection ......................................................................
IMPALA-5838: Improve errors on AC buffer mem rejection The error message returned when a query is rejected due to insufficient buffer memory is misleading. It recommended a mem_limit which would be high enough, but changing the mem_limit may result in changing the plan, which may result in further changes to the buffer memory requirement. In particular, this can happen when the planner compares the expected hash table size to the mem_limit, and decides to choose a partitioned join over a broadcast join. While we might consider other code changes to improve this, for now lets just be clear in the error message. Testing: * Adds tests that verify the expected behavior with the new error message. Change-Id: I3dc3517195508d86078a8a4b537ae7d2f52fbcb7 --- M be/src/scheduling/admission-controller.cc A testdata/workloads/functional-query/queries/QueryTest/admission-reject-min-reservation.test M tests/custom_cluster/test_admission_controller.py 3 files changed, 54 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/7834/2 -- To view, visit http://gerrit.cloudera.org:8080/7834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3dc3517195508d86078a8a4b537ae7d2f52fbcb7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
