Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7834/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: PS2, Line 118: based on mem_limit: " > I find this wording a bit confusing since it's not clear to me upon first r would it be more clear if I put (based on the mem_limit) in parens? -- To view, visit http://gerrit.cloudera.org:8080/7834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dc3517195508d86078a8a4b537ae7d2f52fbcb7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
