Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7834/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: Line 334: #vector.get_value('exec_option')['num_nodes'] = 1 > What's up here? Yeah, fixed that in rev2 already. At first I was toying with this, but then realized the join strategy change is a moot point if it's always run on 1 node. -- To view, visit http://gerrit.cloudera.org:8080/7834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dc3517195508d86078a8a4b537ae7d2f52fbcb7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes