Dan Hecht has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/1/be/src/service/query-options.cc File be/src/service/query-options.cc: Line 113: static int GetQueryOptionForKey(const string& key) { > Nice catch. I don't feel strongly either about this (static makes more sens 'static' seems fine, and is already used in this file. -- To view, visit http://gerrit.cloudera.org:8080/8070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
