Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/1//COMMIT_MSG Commit Message: Line 9: The query 'SET <option>=""' will now unset option, reverting it to A quick question, did you consider other alternatives like "UNSET <option>" or "RESET <option>" before settling for this? Reason being, users might confuse this with NONE. For example, SET COMPRESSION_CODEC="" -> COMPRESSION_CODEC=SNAPPY (default) SET COMPRESSION_CODE=NONE-> COMPRESSION_CODEC=NONE -- To view, visit http://gerrit.cloudera.org:8080/8070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
