Tim Armstrong has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. ......................................................................
Patch Set 2: Code-Review+1 (3 comments) Wrote these up earlier but didn't push them out. http://gerrit.cloudera.org:8080/#/c/8070/1//COMMIT_MSG Commit Message: Line 9: The query 'SET <option>=""' will now unset option, reverting it to > I did, and discussed it somewhat in the JIRA. The new behaviour is more consistent with us reporting the default value of compression_codec as "". The current behaviour of running set compression_codec="" server-side is much weirder - it is just completely ignored. We don't document it as a valid value: https://impala.incubator.apache.org/docs/build/html/topics/impala_compression_codec.html so it seems unlikely that anyone is depending on it. http://gerrit.cloudera.org:8080/#/c/8070/2/be/src/service/query-options.h File be/src/service/query-options.h: PS2, Line 127: unset "reset the key to its default value" I think is more accurate http://gerrit.cloudera.org:8080/#/c/8070/2/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: PS2, Line 80: stirng Thanks, this is helpful nit: string -- To view, visit http://gerrit.cloudera.org:8080/8070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
